Prevent backend from crashing if no inspectionArea #2046
Conversation
| @@ -157,7 +157,7 @@ private async void OnSendRobotToDockTriggered(object? sender, RobotEmergencyEven | |||
| { | |||
| await MissionScheduling.ScheduleMissionToDriveToDockPosition(robot.Id); | |||
| } | |||
| catch (DockException ex) | |||
| catch (Exception ex) when (ex is DockException || ex is InspectionAreaNotFoundException) | |||
There was a problem hiding this comment.
We usually split the expceptions, like this, for consistency:
There was a problem hiding this comment.
I can do it, but the logging and behavior is the same so it would mean duplicated line 161-172. Do you prefer splitting it?
There was a problem hiding this comment.
Btw, we do this in the mapService as well
There was a problem hiding this comment.
The looging messages are different tho, one is regarding docking and the other inspection area so i think it is worth it to duplicate it, it is also consistent with most of the code we have. You don't have to because its a preference but for consistency i think it would be good
There was a problem hiding this comment.
I prefer this. Less chance of getting bugs where only one of the exceptions have forgotten a return or a signalR message
Eddasol
force-pushed
the
dock-causeing-crash
branch
2 times, most recently
from
0d44f20 to
864b49e
Compare
Eddasol
force-pushed
the
dock-causeing-crash
branch
from
864b49e to
13166a6
Compare
Ready for review checklist: